P2P: give the protocol handler access to the peer info #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-p2p
hinto-janai
approved these changes
Sep 30, 2024
Comment on lines
-63
to
+68
| protocol_request_svc: DummyProtocolRequestHandler, | ||
| protocol_request_svc_maker: MapErr::new( | ||
| Shared::new(DummyProtocolRequestHandler), | ||
| tower::BoxError::from, | ||
| ), |
There was a problem hiding this comment.
This infallible is being wrapped and returned in an error to satisfy trait bounds, right?
Co-authored-by: hinto-janai <hinto.janai@protonmail.com>
Boog900
commented
Sep 30, 2024
Cargo.toml
Outdated
| tower = { version = "0.4.13", default-features = false } | ||
| tower = { git = "https://github.com/Cuprate/tower.git", rev = "6c7faf0", default-features = false } |
There was a problem hiding this comment.
I had to fix a bug in tower so until they merge the patch we will need to point to this fork.
Comment on lines
+283
to
+293
| pub trait ProtocolRequestHandlerMaker<Z: NetworkZone>: | ||
| tower::MakeService< | ||
| client::PeerInformation<Z::Addr>, | ||
| ProtocolRequest, | ||
| MakeError = tower::BoxError, | ||
| Service: ProtocolRequestHandler, | ||
| Future: Send + 'static, | ||
| > + Send | ||
| + 'static | ||
| { | ||
| } |
There was a problem hiding this comment.
I added a new trait alias and updated the others to use trait bounds instead of an extra associated type
Comment on lines
+196
to
+197
| /// Changes the protocol request handler maker, which creates the service that handles [`ProtocolRequest`](crate::ProtocolRequest)s | ||
| /// to our node. |
There was a problem hiding this comment.
The handshaker now takes a protocol request handler maker instead of just the request hander
Comment on lines
-63
to
+68
| protocol_request_svc: DummyProtocolRequestHandler, | ||
| protocol_request_svc_maker: MapErr::new( | ||
| Shared::new(DummyProtocolRequestHandler), | ||
| tower::BoxError::from, | ||
| ), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Changes the p2p crates to allow giving the protocol handler access to the peer info.
Why
It is useful to know the peers sync state when handling protocol requests.
Where
Mainly the handshaker/handshaker builder.
How
Uses the
tower::make::*stuff, this allows us to provide an async interface for creating request handlers, which is going to be useful for validating core sync data when handshaking is complete